Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adding missing jsoncomment dependency #14

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix: Adding missing jsoncomment dependency #14

merged 1 commit into from
Feb 29, 2024

Conversation

Gmerold
Copy link
Contributor

@Gmerold Gmerold commented Feb 29, 2024 •
edited
Loading

Description

Latest code changes in the upstream, require jsoncomment.
This PR is adding it to the rock.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@Gmerold Gmerold requested a review from a team as a code owner February 29, 2024 08:27
@Gmerold Gmerold merged commit 4f6df9b into main Feb 29, 2024
10 checks passed
@Gmerold Gmerold deleted the TELCO-1027-adding-missing-jsoncomment-dependency branch February 29, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriciareinoso patriciareinoso patriciareinoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gmerold @patriciareinoso